michaeljmarshall commented on a change in pull request #12248:
URL: https://github.com/apache/pulsar/pull/12248#discussion_r719799082



##########
File path: 
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BaseResource.java
##########
@@ -282,4 +282,21 @@ public static String 
getReasonFromServer(WebApplicationException e) {
             }
         }
     }
+
+    public <T> CompletableFuture<T> getCompletableFuture(WebTarget path) {

Review comment:
       I think this method needs a better name to indicate what it is actually 
doing. It's probably sufficient to overload the `asyncGetRequest` method name 
here and make its signature: 
   
   ```java
   public <T> CompletableFuture<T> getCompletableFuture(WebTarget path)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to