rdhabalia commented on pull request #7499: URL: https://github.com/apache/pulsar/pull/7499#issuecomment-932623893
> since the check is done in background every few seconds (given that LongAdder.sum() is expensive). It's very possible that a traffic spike will to cause an OOM between the checks. It actually performs at every second and ticker time can be configurable to make sure at any point broker doesn't exceed the limit. infact 1 sec is also a reasonable number most of the time because the load will not spike to take 100% memory in 1 second but in any case it can be configurable. will take make sense? > (given that LongAdder.sum() is expensive) yes, it happens in a separate a thread similar to stats and other throttling usecase to use LongAdder for the aggregation. So, it won't impact write path latency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
