EronWright commented on a change in pull request #11988:
URL: https://github.com/apache/pulsar/pull/11988#discussion_r721153523



##########
File path: site2/website/versioned_docs/version-2.8.1/security-oauth2.md
##########
@@ -29,7 +29,7 @@ The following table lists parameters supported for the 
`client credentials` auth
 | `type` | Oauth 2.0 authentication type. |  `client_credentials` (default) | 
Optional |
 | `issuerUrl` | URL of the authentication provider which allows the Pulsar 
client to obtain an access token | `https://accounts.google.com` | Required |
 | `privateKey` | URL to a JSON credentials file  | Support the following 
pattern formats: <br> <li> `file:///path/to/file` <li>`file:/path/to/file` <li> 
`data:application/json;base64,<base64-encoded value>` | Required |
-| `audience`  | An OAuth 2.0 "resource server" identifier for the Pulsar 
cluster | `https://broker.example.com` | Required |
+| `audience`  | An OAuth 2.0 "resource server" identifier for the Pulsar 
cluster. Required by some Identity Providers. | `https://broker.example.com` | 
Optional |

Review comment:
       I don't understand what would be the benefit of this suggestion.  This 
change looks good to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to