liangyepianzhou opened a new pull request #12276:
URL: https://github.com/apache/pulsar/pull/12276


   ### Motivation
   Return the future returned by thenAccept() to the method caller. Make the 
caller can control the order of code execution
   
   ### Modifications
   Modify private void takeSnapshot() to private CompletableFuture<Void> 
takeSnapshot().
   
   ### Verifying this change
   I think there is no need to add a test to verify this change.
   If need to add test here, please leave a comment to remind me. Thanks. 
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [x] no-need-doc 
   Here is the modification of the code details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to