cckellogg commented on a change in pull request #631:
URL: https://github.com/apache/pulsar-client-go/pull/631#discussion_r723331695
##########
File path: pulsar/internal/connection.go
##########
@@ -884,10 +882,8 @@ func (c *connection) Close() {
}
func (c *connection) changeState(state connectionState) {
- c.Lock()
Review comment:
Are there other places in the code that call `changeState` with the
assumption that it holds the lock?
Let's leave a comment near the Broadcast saying it's ok to call the
broadcast here even without the lock (I had to looks at the docs to make sure
that was the case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
