congbobo184 opened a new pull request #12301:
URL: https://github.com/apache/pulsar/pull/12301


   ## Motivation
   now https://github.com/apache/pulsar/pull/11357 has merged, 
https://github.com/apache/pulsar/pull/11357 use `SUCCESS` command handle 
tcClientConnectRequest, This is not conducive to later expansion. So add a 
individual response for `CommandTcClientConnectRequest`
   
   ## implement
   add command 
   ```
   message CommandTcClientConnectResponse {
       required uint64 request_id = 1;
       optional ServerError error  = 2;
       optional string message     = 3;
   }
   ```
   
   In order to ensure that the new client is compatible with the old broker, I 
update protocol version to 19.
   
   ```
       v19 = 19; // Add CommandTcClientConnectRequest and 
CommandTcClientConnectResponse
   ```
   if broker protocol version > 18 we should send TcClientConnectCommand
   if broker protocol version <= 18 we don't need to send TcClientConnectCommand
   
   Does this pull request potentially affect one of the following parts:
   If yes was chosen, please highlight the changes
   
   Dependencies (does it add or upgrade a dependency): (no)
   The public API: (no)
   The schema: (no)
   The default values of configurations: (no)
   The wire protocol: (yes)
   The rest endpoints: (no)
   The admin cli options: (no)
   Anything that affects deployment: (no)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to