BewareMyPower opened a new pull request #12305:
URL: https://github.com/apache/pulsar/pull/12305


   ### Motivation
   
   It's a C++ client catchup for https://github.com/apache/pulsar/pull/11931.
   
   ### Modifications
   
   - Add a `scope_` field to `ClientCredentialFlow` and load it from `ParamMap` 
object whose key is `scope`.
   - Refactor `ClientCredentialFlow` to simplify code and make it testable:
     - Use only one constructor instead of two overloaded constructors that 
might look confused
     - Add a `generateJsonBody` public method for generating JSON body for post 
fields in `authenticate` so that it can be tested.
     - Add a `KeyFile` class like what Java client does to load client id and 
client secret from `ParamMap` or file.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added test `AuthPluginTest.testOauth2RequestBody` for the cases 
that scope exists or doesn't exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to