merlimat commented on a change in pull request #12298:
URL: https://github.com/apache/pulsar/pull/12298#discussion_r725392291



##########
File path: distribution/server/src/assemble/bin.xml
##########
@@ -121,7 +121,7 @@
     <dependencySet>
       <outputDirectory>lib</outputDirectory>
       <unpack>false</unpack>
-      <scope>compile</scope>
+      <scope>runtime</scope>

Review comment:
       We can potentially also remove some of the excludes below, because they 
shouldn't be getting picket up anymore: 
   
   ```
           <exclude>org.apache.pulsar:pulsar-functions-runtime-all</exclude>
           <exclude>org.projectlombok:lombok</exclude>
           <!-- prevent adding pulsar-functions-api-examples in lib -->
           <exclude>org.apache.pulsar:pulsar-functions-api-examples</exclude>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to