Jason918 opened a new pull request #12308:
URL: https://github.com/apache/pulsar/pull/12308
Fixes #12291
### Motivation
Bug fix. 'StartMessageId' and 'RollbackDuration' is not working in
MultiTopicsReader for non-partitioned topics.
### Modifications
This fix is quite simple. Just add `startMessageId` and
`startMessageRollbackDurationInSec` when creating underlying consumer with
`ConsumerImpl.newConsumerImpl`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
-
org.apache.pulsar.client.impl.MultiTopicsReaderTest#testMultiNonPartitionedTopicWithStartMessageId
-
org.apache.pulsar.client.impl.MultiTopicsReaderTest#testMultiNonPartitionedTopicWithRollbackDuration
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] no-need-doc
(Please explain why) simple bug fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
