[pulsar] branch master updated: Use asyncCloseCursorLedger to replace cursorLedger.asyncClose method in the ManagedCursorImpl.VoidCallback#operationComplete (#12113)

[bogong]

This is an automated email from the ASF dual-hosted git repository.

bogong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 508ef82  Use asyncCloseCursorLedger to replace cursorLedger.asyncClose 
method in the ManagedCursorImpl.VoidCallback#operationComplete (#12113)
508ef82 is described below

commit 508ef8207bed48d609ef065745e8d63a3ed543a7
Author: chenlin <1572139...@qq.com>
AuthorDate: Thu Oct 14 16:38:46 2021 +0800

    Use asyncCloseCursorLedger to replace cursorLedger.asyncClose method in the 
ManagedCursorImpl.VoidCallback#operationComplete (#12113)
    
    The 
org.apache.bookkeeper.mledger.impl.ManagedCursorImpl#asyncCloseCursorLedger 
method is an unused method, delete the redundant method
---
 .../bookkeeper/mledger/impl/ManagedCursorImpl.java      | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
index 516c2af..235736d 100644
--- 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
+++ 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
@@ -2235,18 +2235,7 @@ public class ManagedCursorImpl implements ManagedCursor {
                         public void operationComplete() {
                             log.info("[{}][{}] Updated md-position={} into 
cursor-ledger {}", ledger.getName(), name,
                                     markDeletePosition, cursorLedger.getId());
-                            cursorLedger.asyncClose((rc, lh, ctx1) -> {
-                                callback.closeComplete(ctx);
-
-                                if (rc == BKException.Code.OK) {
-                                    log.info("[{}][{}] Closed cursor-ledger 
{}", ledger.getName(), name,
-                                            cursorLedger.getId());
-                                } else {
-                                    log.warn("[{}][{}] Failed to close 
cursor-ledger {}: {}", ledger.getName(), name,
-                                            cursorLedger.getId(), 
BKException.getMessage(rc));
-                                }
-                            }, ctx);
-
+                            asyncCloseCursorLedger(callback, ctx);
                         }
 
                         @Override
@@ -2733,8 +2722,12 @@ public class ManagedCursorImpl implements ManagedCursor {
             public void closeComplete(int rc, LedgerHandle lh, Object ctx) {
                 ledger.mbean.endCursorLedgerCloseOp();
                 if (rc == BKException.Code.OK) {
+                    log.info("[{}][{}] Closed cursor-ledger {}", 
ledger.getName(), name,
+                            cursorLedger.getId());
                     callback.closeComplete(ctx);
                 } else {
+                    log.warn("[{}][{}] Failed to close cursor-ledger {}: {}", 
ledger.getName(), name,
+                            cursorLedger.getId(), BKException.getMessage(rc));
                     callback.closeFailed(createManagedLedgerException(rc), 
ctx);
                 }
             }