merlimat commented on a change in pull request #12344:
URL: https://github.com/apache/pulsar/pull/12344#discussion_r729961589



##########
File path: 
pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyServiceStarterTest.java
##########
@@ -51,15 +52,21 @@
     static final String[] ARGS = new String[]{"-c", 
"./src/test/resources/proxy.conf"};
 
     private ProxyServiceStarter serviceStarter;
+    private static final int WEB_SERVICE_PORT = PortManager.nextFreePort();
+    private static final int SERVICE_PORT = PortManager.nextFreePort();

Review comment:
       Instead of using `PortManager`, the ports should be set to 0, so they're 
left to be assigned by the system and we avoid conflicts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to