eolivelli commented on a change in pull request #12353:
URL: https://github.com/apache/pulsar/pull/12353#discussion_r729749885
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/validator/MultipleListenerValidator.java
##########
@@ -38,8 +38,7 @@
public final class MultipleListenerValidator {
/**
- * validate the configure of `advertisedListeners`,
`internalListenerName`, `advertisedAddress`.
- * 1. `advertisedListeners` and `advertisedAddress` must not appear
together.
+ * Validate the configuration of `advertisedListeners`,
`internalListenerName`.
* 2. the listener name in `advertisedListeners` must not duplicate.
Review comment:
good catch
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/validator/MultipleListenerValidator.java
##########
@@ -38,8 +38,7 @@
public final class MultipleListenerValidator {
/**
- * validate the configure of `advertisedListeners`,
`internalListenerName`, `advertisedAddress`.
- * 1. `advertisedListeners` and `advertisedAddress` must not appear
together.
+ * Validate the configuration of `advertisedListeners`,
`internalListenerName`.
* 2. the listener name in `advertisedListeners` must not duplicate.
Review comment:
@tomscut can you please send a PR to fix this ?
I am going to merge this patch now and prepare 2.9.0 release soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
