This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 6809c6c90497390ecfd49dbb1017428bb12bec55 Author: Hang Chen <[email protected]> AuthorDate: Thu Oct 14 14:34:41 2021 +0800 Update delete inactive topic configuration documentation (#12350) ### Motivation When users turn on brokerDeleteInactiveTopics and turn off allowAutoTopicCreation, the broker will delete some inactive partitions of the topic and can't be created when new producers and consumers connected to it. It will make users confused. In fact, the brokerDeleteInactiveTopicsEnabled need to cooperate with allowAutoTopicCreation parameters. If brokerDeleteInactiveTopicsEnabled is set to true, we should ensure that allowAutoTopicCreation is also set to true. ### Modification Add some comments for brokerDeleteInactiveTopicsEnabled parameter to clarify its usage. (cherry picked from commit 09e5a86cd902f5a1ca6404d20039f16e6620960c) --- conf/broker.conf | 3 ++- conf/standalone.conf | 3 ++- deployment/terraform-ansible/templates/broker.conf | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/conf/broker.conf b/conf/broker.conf index d81e86c..6e4668b 100644 --- a/conf/broker.conf +++ b/conf/broker.conf @@ -152,7 +152,8 @@ allowAutoSubscriptionCreation=true # The number of partitioned topics that is allowed to be automatically created if allowAutoTopicCreationType is partitioned. defaultNumPartitions=1 -# Enable the deletion of inactive topics +# Enable the deletion of inactive topics. This parameter need to cooperate with the allowAutoTopicCreation parameter. +# If brokerDeleteInactiveTopicsEnabled is set to true, we should ensure that allowAutoTopicCreation is also set to true. brokerDeleteInactiveTopicsEnabled=true # How often to check for inactive topics diff --git a/conf/standalone.conf b/conf/standalone.conf index e13723f..a76736a 100644 --- a/conf/standalone.conf +++ b/conf/standalone.conf @@ -99,7 +99,8 @@ backlogQuotaDefaultLimitSecond=-1 # Default ttl for namespaces if ttl is not already configured at namespace policies. (disable default-ttl with value 0) ttlDurationDefaultInSeconds=0 -# Enable the deletion of inactive topics +# Enable the deletion of inactive topics. This parameter need to cooperate with the allowAutoTopicCreation parameter. +# If brokerDeleteInactiveTopicsEnabled is set to true, we should ensure that allowAutoTopicCreation is also set to true. brokerDeleteInactiveTopicsEnabled=true # How often to check for inactive topics diff --git a/deployment/terraform-ansible/templates/broker.conf b/deployment/terraform-ansible/templates/broker.conf index 89b8dde..2ec4def 100644 --- a/deployment/terraform-ansible/templates/broker.conf +++ b/deployment/terraform-ansible/templates/broker.conf @@ -119,7 +119,8 @@ allowAutoSubscriptionCreation=true # The number of partitioned topics that is allowed to be automatically created if allowAutoTopicCreationType is partitioned. defaultNumPartitions=1 -# Enable the deletion of inactive topics +# Enable the deletion of inactive topics. This parameter need to cooperate with the allowAutoTopicCreation parameter. +# If brokerDeleteInactiveTopicsEnabled is set to true, we should ensure that allowAutoTopicCreation is also set to true. brokerDeleteInactiveTopicsEnabled=true # How often to check for inactive topics
