315157973 commented on a change in pull request #12367:
URL: https://github.com/apache/pulsar/pull/12367#discussion_r730537683
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java
##########
@@ -2596,7 +2596,7 @@ public void testPoliciesCanBeDeletedWithTopic() throws
Exception {
}
}
consumer.close();
- assertEquals(count, 1);
+ assertEquals(count, 2);
Review comment:
If the message value is not set to null, then the message will not be
cleaned by the compaction topic. You fixed an NPE, but introduced another bug.
We only need to fix the NPE.
In addition, please add unit tests to cover NPE scenarios
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
