letterwuyu commented on a change in pull request #12369:
URL: https://github.com/apache/pulsar/pull/12369#discussion_r730615140
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##########
@@ -527,7 +527,9 @@ private void recoveredCursor(PositionImpl position,
Map<String, Long> properties
log.info("[{}] [{}] Couldn't find next next valid ledger for
recovery {}", ledger.getName(), name,
position);
}
- position = nextExistingLedger != null ?
PositionImpl.get(nextExistingLedger, -1) : position;
Review comment:
Yes, maybe, from the readability, we should not add unnecessary logic,
we should try to keep the code concise and sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
