gaoran10 commented on a change in pull request #12386:
URL: https://github.com/apache/pulsar/pull/12386#discussion_r731959296
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -455,9 +455,14 @@ public void
syncMaxReadPositionForNormalPublish(PositionImpl position) {
// when ongoing transaction is empty, proved that lastAddConfirm is
can read max position, because callback
// thread is the same tread, in this time the lastAddConfirm don't
content transaction message.
synchronized (TopicTransactionBuffer.this) {
- if (ongoingTxns.isEmpty()) {
+ if (checkIfNoSnapshot()) {
maxReadPosition = position;
changeMaxReadPositionAndAddAbortTimes.incrementAndGet();
+ } else if (checkIfReady()) {
+ if (ongoingTxns.isEmpty()) {
Review comment:
I think this is ok because that each transaction message may update the
`maxReadPosition`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
