lordcheng10 commented on a change in pull request #12362:
URL: https://github.com/apache/pulsar/pull/12362#discussion_r733607536
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
##########
@@ -120,12 +120,21 @@ private void readAsync(int numberOfEntriesToRead,
cursor.asyncClose(new AsyncCallbacks.CloseCallback() {
@Override
public void closeComplete(Object ctx) {
- try {
- managedLedger.close();
- } catch (Exception e) {
- completableFuture.completeExceptionally(e);
- }
- completableFuture.complete(null);
+ managedLedger.asyncClose(new AsyncCallbacks.CloseCallback() {
+
+ @Override
+ public void closeComplete(Object ctx) {
+ log.error("[{}][{}] MLPendingAckStore closed
successfully！", managedLedger.getName(), ctx);
Review comment:
please review again. thanks. @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
