dlg99 commented on a change in pull request #12457:
URL: https://github.com/apache/pulsar/pull/12457#discussion_r734208736
##########
File path:
pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarOffsetBackingStore.java
##########
@@ -158,19 +158,35 @@ public void start() {
@Override
public void stop() {
+ log.info("Stopping PulsarOffsetBackingStore");
if (null != producer) {
+ try {
+ producer.flush();
Review comment:
@hangc0276 in that case exception from flush prevent close(). We do want
to close the producer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
