michaeljmarshall commented on a change in pull request #12302:
URL: https://github.com/apache/pulsar/pull/12302#discussion_r735801083
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2331,7 +2331,7 @@ Options
|---|---|---|
|`-s`, `--subscription`|Subscription to reset position on||
|`-t`, `--time`|The time in minutes to reset back to (or minutes, hours, days,
weeks, etc.). Examples: `100m`, `3h`, `2d`, `5w`.||
-|`-m`, `--messageId`| The messageId to reset back to (ledgerId:entryId). ||
+|`-m`, `--messageId`| The messageId to reset back to (ledgerId:entryId or
earliest/latest). ||
Review comment:
I agree that the `/` could be slightly confusing and that it would be
clearer to separate the `earliest` and `latest` options. See my other comment
for my proposed change.
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##########
@@ -771,7 +771,8 @@ void run() throws PulsarAdminException {
private String resetTimeStr;
@Parameter(names = { "--messageId",
- "-m" }, description = "messageId to reset back to
(ledgerId:entryId)", required = false)
+ "-m" }, description = "messageId to reset back to
(ledgerId:entryId or earliest/latest)", required =
Review comment:
Note that the `CreateSubscription` description says: `It can be either
'latest', 'earliest' or (ledgerId:entryId)`. We could match it here with
```suggestion
"-m" }, description = "messageId to reset back to ('latest',
'earliest', or 'ledgerId:entryId')", required =
```
I don't think we should include the parentheses around `ledgerId:entryId`
because the expected format does not have parentheses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
