315157973 commented on a change in pull request #12392:
URL: https://github.com/apache/pulsar/pull/12392#discussion_r738033428
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java
##########
@@ -1698,8 +1698,8 @@ public void testSubscriptionTypesEnabled() throws
PulsarAdminException, PulsarCl
}
// clear all namespace subType enabled, add failover to broker.conf
and sub with shared will fail
- subscriptionTypes.clear();
- admin.namespaces().setSubscriptionTypesEnabled(namespace,
subscriptionTypes);
+ admin.namespaces().removeSubscriptionTypesEnabled(namespace);
+
assertEquals(admin.namespaces().getSubscriptionTypesEnabled(namespace),
Sets.newHashSet());
Review comment:
Please keep it consistent with other remove interfaces, and set the
value to null when deleting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
