Jason918 commented on a change in pull request #12536:
URL: https://github.com/apache/pulsar/pull/12536#discussion_r739596906
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1008,6 +1008,11 @@
)
private boolean disableBrokerInterceptors = true;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "List of interceptors for payload processing.")
+ private String brokerEntryPayloadProcessor;
Review comment:
It could be a list of interceptors, so the type should be Set<String>.
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryImpl.java
##########
@@ -47,12 +48,22 @@ protected EntryImpl newObject(Handle<EntryImpl> handle) {
ByteBuf data;
public static EntryImpl create(LedgerEntry ledgerEntry) {
+ return create(ledgerEntry,null);
+ }
+
+ public static EntryImpl create(LedgerEntry ledgerEntry,
ManagedLedgerInterceptor managedLedgerInterceptor) {
Review comment:
Put the 'managedLedgerInterceptor' in here seem a little strange.
IMHO, it's better put outside of `create`, the `managedLedgerInterceptor`
processes the `ledgerEntry` and then pass the result to this create method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
