merlimat commented on a change in pull request #12569:
URL: https://github.com/apache/pulsar/pull/12569#discussion_r740319567
##########
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java
##########
@@ -407,6 +410,16 @@ public static void main(String[] args) throws Exception {
Histogram reportHistogram = null;
+ String statsFileName = "perf-consumer-" + System.currentTimeMillis() +
".hgrm";
Review comment:
This should probably be turned off by default
##########
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java
##########
@@ -407,6 +410,16 @@ public static void main(String[] args) throws Exception {
Histogram reportHistogram = null;
+ String statsFileName = "perf-consumer-" + System.currentTimeMillis() +
".hgrm";
Review comment:
Yes, I think we should also disable for producer as most of the time
people are not going to make use of the histograms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
