BewareMyPower commented on a change in pull request #12586:
URL: https://github.com/apache/pulsar/pull/12586#discussion_r741562946
##########
File path: pulsar-client-cpp/lib/ClientConnection.cc
##########
@@ -1620,7 +1620,12 @@ Future<Result, MessageId>
ClientConnection::newGetLastMessageId(uint64_t consume
pendingGetLastMessageIdRequests_.insert(std::make_pair(requestId,
promise));
lock.unlock();
- sendRequestWithId(Commands::newGetLastMessageId(consumerId, requestId),
requestId);
+ sendRequestWithId(Commands::newGetLastMessageId(consumerId, requestId),
requestId)
Review comment:
I agree. I'll remove the unnecessary refactoring of this class but still
add some changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
