This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new f65f272  [Functions] Prevent NPE while stopping a non started Pulsar 
LogAppender (#12643)
f65f272 is described below

commit f65f2721d06b42a751909480191cd8cefef7b856
Author: Enrico Olivelli <[email protected]>
AuthorDate: Fri Nov 5 17:12:33 2021 +0100

    [Functions] Prevent NPE while stopping a non started Pulsar LogAppender 
(#12643)
---
 .../java/org/apache/pulsar/functions/instance/LogAppender.java    | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/LogAppender.java
 
b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/LogAppender.java
index 20354d4..5250e4c 100644
--- 
a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/LogAppender.java
+++ 
b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/LogAppender.java
@@ -108,7 +108,7 @@ public class LogAppender implements Appender {
                     .property("function", fqn)
                     .create();
         } catch (Exception e) {
-            throw new RuntimeException("Error starting LogTopic Producer", e);
+            throw new RuntimeException("Error starting LogTopic Producer for 
function " + fqn, e);
         }
         this.state = State.STARTED;
     }
@@ -116,8 +116,10 @@ public class LogAppender implements Appender {
     @Override
     public void stop() {
         this.state = State.STOPPING;
-        producer.closeAsync();
-        producer = null;
+        if (producer != null) {
+            producer.closeAsync();
+            producer = null;
+        }
         this.state = State.STOPPED;
     }
 

Reply via email to