zymap commented on a change in pull request #660:
URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r742825857
##########
File path: pulsar/consumer_regex.go
##########
@@ -183,6 +183,22 @@ func (c *regexConsumer) AckID(msgID MessageID) {
}
func (c *regexConsumer) Nack(msg Message) {
+ if c.options.EnableDefaultNackBackoffPolicy ||
c.options.NackBackoffPolicy != nil {
Review comment:
```suggestion
if c.options.EnableDefaultNackBackoffPolicy &&
c.options.NackBackoffPolicy != nil {
```
##########
File path: pulsar/consumer_multitopic.go
##########
@@ -164,6 +164,22 @@ func (c *multiTopicConsumer) ReconsumeLater(msg Message,
delay time.Duration) {
}
func (c *multiTopicConsumer) Nack(msg Message) {
+ if c.options.EnableDefaultNackBackoffPolicy ||
c.options.NackBackoffPolicy != nil {
Review comment:
```suggestion
if c.options.EnableDefaultNackBackoffPolicy &&
c.options.NackBackoffPolicy != nil {
```
##########
File path: pulsar/consumer_impl.go
##########
@@ -489,6 +495,20 @@ func (c *consumer) ReconsumeLater(msg Message, delay
time.Duration) {
}
func (c *consumer) Nack(msg Message) {
+ if c.options.EnableDefaultNackBackoffPolicy ||
c.options.NackBackoffPolicy != nil {
Review comment:
```suggestion
if c.options.EnableDefaultNackBackoffPolicy &&
c.options.NackBackoffPolicy != nil {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
