liangyepianzhou removed a comment on pull request #12636: URL: https://github.com/apache/pulsar/pull/12636#issuecomment-962404540
There is a problem here: When a NonRecoverableLedgerException appears, do we need to move the cusor in the FillEntryQueueCallback of TransactionBufferd or directly end this recoveration? When I was writing the test, I found that readEntriesFailed in FillEntryQueueCallback of TransactionBufferd was not called at all when this exception occurred. Later I found that when a NonRecoverableLedgerException occurs, OpReadEntry will process and move the cusor, and only when there is no a nextReadPosition will readEntriesFailed in FillEntryQueueCallback of TransactionBufferd be called. So I think the recover can be ended directly, there is no problem with the previous implementation. Do you think so? @ @codelipenghui @congbobo184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
