lhotari opened a new pull request #12666:
URL: https://github.com/apache/pulsar/pull/12666


   ### Motivation
   
   - https://github.com/apache/bookkeeper/pull/2646 added "Auto-throttle read 
operations" which is enabled by default
   
   ### Modifications
   
   - Add `readWorkerThreadsThrottlingEnabled=true` to `conf/bookkeeper.conf` 
since that is the default value in BookKeeper that gets used unless the setting 
is explicitly set to `false`. 
   
   ### Open questions
   
   - Is `readWorkerThreadsThrottlingEnabled=true` a safe default?
     - There's a warning in 
https://netty.io/4.0/api/io/netty/channel/ChannelFuture.html about calling 
`.await()` and https://github.com/apache/bookkeeper/pull/2646 uses that 
`ChannelFuture.await()` to block.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to