codelipenghui commented on a change in pull request #11325:
URL: https://github.com/apache/pulsar/pull/11325#discussion_r746547184
##########
File path: conf/broker.conf
##########
@@ -327,6 +327,14 @@ brokerPublisherThrottlingMaxMessageRate=0
# (Disable byte rate limit with value 0)
brokerPublisherThrottlingMaxByteRate=0
+# Max Rate(in 1 seconds) of Message allowed to dispatch from a broker if
broker dispatch rate limiting enabled
+# (Disable message rate limit with value 0)
+brokerDispatchThrottlingMaxMessageRate=0
Review comment:
```suggestion
dispatchThrottlingRateInMsg=0
```
##########
File path: conf/broker.conf
##########
@@ -327,6 +327,14 @@ brokerPublisherThrottlingMaxMessageRate=0
# (Disable byte rate limit with value 0)
brokerPublisherThrottlingMaxByteRate=0
+# Max Rate(in 1 seconds) of Message allowed to dispatch from a broker if
broker dispatch rate limiting enabled
+# (Disable message rate limit with value 0)
+brokerDispatchThrottlingMaxMessageRate=0
+
+# Max Rate(in 1 seconds) of Byte allowed to dispatch from a broker if broker
dispatch rate limiting enabled.
+# (Disable byte rate limit with value 0)
+brokerDispatchThrottlingMaxByteRate=0
Review comment:
```suggestion
dispatchThrottlingRateInByte=0
```
##########
File path: conf/broker.conf
##########
@@ -327,6 +327,14 @@ brokerPublisherThrottlingMaxMessageRate=0
# (Disable byte rate limit with value 0)
brokerPublisherThrottlingMaxByteRate=0
+# Max Rate(in 1 seconds) of Message allowed to dispatch from a broker if
broker dispatch rate limiting enabled
+# (Disable message rate limit with value 0)
+brokerDispatchThrottlingMaxMessageRate=0
+
+# Max Rate(in 1 seconds) of Byte allowed to dispatch from a broker if broker
dispatch rate limiting enabled.
+# (Disable byte rate limit with value 0)
+brokerDispatchThrottlingMaxByteRate=0
Review comment:
And we already have some `dispatchThrottling` related configurations
such as `dispatchThrottlingRatePerTopicInByte`, it's better to put them
together and follow the same name pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
