Jason918 commented on a change in pull request #12741:
URL: https://github.com/apache/pulsar/pull/12741#discussion_r747284538
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/SimpleLoadManagerImpl.java
##########
@@ -559,15 +556,17 @@ private synchronized void updateRealtimeResourceQuota() {
}
private void compareAndWriteQuota(String bundle, ResourceQuota oldQuota,
ResourceQuota newQuota) throws Exception {
- boolean needUpdate = true;
- if (!oldQuota.getDynamic() || (Math
- .abs(newQuota.getMsgRateIn() - oldQuota.getMsgRateIn()) <
RESOURCE_QUOTA_MIN_MSGRATE_IN
- && Math.abs(newQuota.getMsgRateOut() -
oldQuota.getMsgRateOut()) < RESOURCE_QUOTA_MIN_MSGRATE_OUT
- && Math.abs(newQuota.getBandwidthIn() -
oldQuota.getBandwidthOut()) < RESOURCE_QUOTA_MIN_BANDWIDTH_IN
- && Math.abs(newQuota.getBandwidthOut() -
oldQuota.getBandwidthOut()) < RESOURCE_QUOTA_MIN_BANDWIDTH_OUT
- && Math.abs(newQuota.getMemory() - oldQuota.getMemory()) <
RESOURCE_QUOTA_MIN_MEMORY)) {
- needUpdate = false;
- }
+ boolean needUpdate = oldQuota.getDynamic() && (!(Math
Review comment:
IMHO, the previous code format is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
