massakam commented on a change in pull request #12769:
URL: https://github.com/apache/pulsar/pull/12769#discussion_r747975814
##########
File path: pulsar-client-cpp/lib/CMakeLists.txt
##########
@@ -20,7 +20,7 @@
file(GLOB PULSAR_SOURCES *.cc *.h lz4/*.cc lz4/*.h checksum/*.cc checksum/*.h
stats/*.cc stats/*.h c/*.cc c/*.h auth/*.cc auth/*.h auth/athenz/*.cc
auth/athenz/*.h)
execute_process(COMMAND python
${CMAKE_SOURCE_DIR}/../src/get-project-version.py
OUTPUT_STRIP_TRAILING_WHITESPACE OUTPUT_VARIABLE PV)
-set (CMAKE_CXX_FLAGS " ${CMAKE_CXX_FLAGS} -D_PULSAR_VERSION_=\\\"${PV}\\\"")
+set (CMAKE_CXX_FLAGS " ${CMAKE_CXX_FLAGS}
-D_PULSAR_VERSION_INTERNAL_=\\\"${PV}\\\"")
Review comment:
I renamed this existing macro to avoid confusion with the macro added
this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
