BewareMyPower commented on issue #12616:
URL: https://github.com/apache/pulsar/issues/12616#issuecomment-966821952


   We should evaluate the influence if we updated `lastConfirmedEntry` in 
`internalTrimLedgers`. Because some methods might rely on the current semantics 
that `lastConfirmedEntry` can point to a deleted entry.
   
   Unless we can add a unit test to prove the current semantics might cause 
some problems, we should not change it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to