codelipenghui commented on a change in pull request #12403:
URL: https://github.com/apache/pulsar/pull/12403#discussion_r748352882
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -61,6 +61,9 @@ message MessageIdData {
optional int32 batch_index = 4 [default = -1];
repeated int64 ack_set = 5;
optional int32 batch_size = 6;
+
+ // For the chunk message id, we need to specify the first chunk message id.
+ optional MessageIdData first_chunk_message_id = 7;
Review comment:
@rdhabalia This one is only for the `MessageId.toByteArray()` method, it
is a little tricky to add to the wire protocol, but currently we are using the
`MessageIdData` to generate the byte array for users, it's will not pass to the
broker side let the broker know which one is the first chunk message ID.
Users can store the byte array of the chunk message ID, so that they can
recover a chunk message ID by the byte array. If they want to seek to this
chunk message continues to consume data with inclusive mode, they don't need to
do lots of staff.
And introducing the new chunk message ID will allow us to peek the message
from the topic if the application recorded the chunk message ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
