sijia-w commented on a change in pull request #12745:
URL: https://github.com/apache/pulsar/pull/12745#discussion_r748846831



##########
File path: site2/docs/concepts-messaging.md
##########
@@ -316,10 +316,11 @@ A subscription is a named configuration rule that 
determines how messages are de
 > * If you want to achieve "message queuing" among consumers, share the same 
 > subscription name among multiple consumers(shared, failover, key_shared).
 > * If you want to achieve both effects simultaneously, combine exclusive 
 > subscription type with other subscription types for consumers.
 
-### Consumerless Subscriptions and Their Corresponding Types
+### Subscriptions type

Review comment:
       Shall we use `Subscription Types` instead?

##########
File path: site2/docs/concepts-messaging.md
##########
@@ -396,6 +397,57 @@ producer = client.create_producer(topic='my-topic', 
batching_type=pulsar.Batchin
 > * You need to specify a key or orderingKey for messages.
 > * You cannot use cumulative acknowledgment with Key_Shared type.
 
+### Subscription mode

Review comment:
       This heading should be in the same format of `Subscription Types`. I 
suggest we use `Subscription Modes`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to