cckellogg commented on a change in pull request #648:
URL: https://github.com/apache/pulsar-client-go/pull/648#discussion_r751441706
##########
File path: pulsar/producer_partition.go
##########
@@ -742,6 +747,10 @@ func (p *partitionProducer) internalSendAsync(ctx
context.Context, msg *Producer
callback(nil, msg, errProducerClosed)
return
}
+ if p.err != nil {
Review comment:
This now changes the current behavior. Before if there was room the
message would be added to the pending queue and sent when a new connection is
established. Now the message will not be added. I'm not sure changing the
default behavior is the correct approach here. Also, there could be a race
condition checking the error and sending it since the the error is set in
another go routine?
How do you envision your application handling this error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
