michaeljmarshall commented on a change in pull request #12846:
URL: https://github.com/apache/pulsar/pull/12846#discussion_r751910552



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
##########
@@ -147,22 +147,17 @@ private String parseRemoteClusterName(String 
producerName, boolean isRemote) {
         return null;
     }
 
-    @Override

Review comment:
       The tests I've added/updated should fail if the definition of equality 
changes or becomes too broad. If you are worried that the tests are 
insufficient, I'm happy to add the overrides back in. Let me know.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to