com-poorbar commented on a change in pull request #12792:
URL: https://github.com/apache/pulsar/pull/12792#discussion_r752879058
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentFailoverE2ETest.java
##########
@@ -99,6 +100,11 @@ public void becameInactive(Consumer<?> consumer, int
partitionId) {
} catch (InterruptedException e) {
}
}
+
+ @Override
+ public void keySharedRuleChanged(Consumer<?> consumer,
Predicate<String> keyPredicate) {
Review comment:
Already revised
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java
##########
@@ -148,4 +156,29 @@ public Consumer select(int hash) {
Map<Integer, List<Consumer>> getRangeConsumer() {
return Collections.unmodifiableMap(hashRing);
}
+
+ @Override
+ public StickyKeyConsumerPredicate generateSpecialPredicate(final Consumer
consumer){
+ NavigableMap<Integer, List<String>> cpHashRing = new
ConcurrentSkipListMap<>();
Review comment:
Already revised
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java
##########
@@ -74,6 +80,7 @@ public void addConsumer(Consumer consumer) throws
ConsumerAssignException {
}
});
}
+ notifyActiveConsumerChanged();
Review comment:
Already revised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
