RobertIndie commented on a change in pull request #12872:
URL: https://github.com/apache/pulsar/pull/12872#discussion_r752927408
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -1318,9 +1318,9 @@ public void createSubscription(
@ApiParam(value = "Is authentication required to perform this
operation")
@QueryParam("authoritative") @DefaultValue("false") boolean
authoritative,
@ApiParam(name = "messageId", value = "messageId where to create
the subscription. "
- + "It can be 'latest', 'earliest' or (ledgerId:entryId)",
+ + "It can be 'latest', 'earliest' or
(ledgerId:entryId:partitionIndex)",
defaultValue = "latest",
- allowableValues = "latest, earliest, ledgerId:entryId"
+ allowableValues = "latest, earliest,
(ledgerId:entryId:partitionIndex)"
Review comment:
I agree. `ResetCursorData` is more suitable than `MessageIdImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
