Jason918 commented on a change in pull request #12896:
URL: https://github.com/apache/pulsar/pull/12896#discussion_r753619596
##########
File path:
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataCacheTest.java
##########
@@ -331,6 +331,7 @@ public void insertionOutsideCacheWithGenericType(String
provider, Supplier<Strin
});
String key1 = newKey();
+ objCache.get(key1).join();
Review comment:
Changed the test to `updateOutsideCacheWithGenericType` for now.
I think we can implement `insertionOutsideCacheWithGenericType` by make a
path pattern registration or add a method like `accept(path)` for each
MetadataStore instance, which implies the metadata store could deserialization
this value, and the path indeed should be cached in this metadata store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
