michaeljmarshall commented on a change in pull request #12343:
URL: https://github.com/apache/pulsar/pull/12343#discussion_r753858964
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java
##########
@@ -477,13 +477,16 @@ public void flush() {
private void flushAsync(ClientCnx cnx) {
boolean shouldFlush = false;
if (cumulativeAckFlushRequired) {
- newMessageAckCommandAndWrite(cnx, consumer.consumerId,
lastCumulativeAck.messageId.ledgerId,
- lastCumulativeAck.messageId.getEntryId(),
lastCumulativeAck.bitSetRecyclable,
- AckType.Cumulative, null, Collections.emptyMap(), false,
- this.currentCumulativeAckFuture, null);
-
this.consumer.unAckedChunkedMessageIdSequenceMap.remove(lastCumulativeAck.messageId);
- shouldFlush = true;
- cumulativeAckFlushRequired = false;
+ final MessageIdImpl messageIdOfLastAck =
lastCumulativeAck.messageId;
Review comment:
Can you explain why we enter this code block when
`lastCumulativeAck.messageId` is null? It seems like
`cumulativeAckFlushRequired` should be false. I'm fine with adding a null
check, but it seems like there could be another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
