Anonymitaet commented on a change in pull request #12831:
URL: https://github.com/apache/pulsar/pull/12831#discussion_r753913369



##########
File path: pulsar-client-cpp/include/pulsar/c/consumer_configuration.h
##########
@@ -281,6 +281,24 @@ PULSAR_PUBLIC void 
pulsar_consumer_configuration_set_priority_level(
 PULSAR_PUBLIC int pulsar_consumer_configuration_get_priority_level(
     pulsar_consumer_configuration_t *consumer_configuration);
 
+/**
+ * Check whether the replicated subscription is enabled.
+ *
+ * @param consumer_configuration the consumer conf object

Review comment:
       ```suggestion
    * @param consumer_configuration the consumer configuration object
   ```

##########
File path: pulsar-client-cpp/include/pulsar/c/consumer_configuration.h
##########
@@ -281,6 +281,24 @@ PULSAR_PUBLIC void 
pulsar_consumer_configuration_set_priority_level(
 PULSAR_PUBLIC int pulsar_consumer_configuration_get_priority_level(
     pulsar_consumer_configuration_t *consumer_configuration);
 
+/**
+ * Check whether the replicated subscription is enabled.
+ *
+ * @param consumer_configuration the consumer conf object
+ * @return whether the replicated subscription is enabled.
+ */
+PULSAR_PUBLIC int pulsar_consumer_is_replicate_subscription_state_enabled(
+    pulsar_consumer_configuration_t *consumer_configuration);
+
+/**
+ * Enable/disable replicated subscription 

Review comment:
       ```suggestion
    * Enable or disable replicated subscription 
   ```

##########
File path: pulsar-client-cpp/include/pulsar/c/consumer_configuration.h
##########
@@ -281,6 +281,24 @@ PULSAR_PUBLIC void 
pulsar_consumer_configuration_set_priority_level(
 PULSAR_PUBLIC int pulsar_consumer_configuration_get_priority_level(
     pulsar_consumer_configuration_t *consumer_configuration);
 
+/**
+ * Check whether the replicated subscription is enabled.
+ *
+ * @param consumer_configuration the consumer conf object
+ * @return whether the replicated subscription is enabled.
+ */
+PULSAR_PUBLIC int pulsar_consumer_is_replicate_subscription_state_enabled(
+    pulsar_consumer_configuration_t *consumer_configuration);
+
+/**
+ * Enable/disable replicated subscription 
+ *
+ * @param consumer_configuration the consumer conf object

Review comment:
       same

##########
File path: pulsar-client-cpp/include/pulsar/c/consumer_configuration.h
##########
@@ -281,6 +281,24 @@ PULSAR_PUBLIC void 
pulsar_consumer_configuration_set_priority_level(
 PULSAR_PUBLIC int pulsar_consumer_configuration_get_priority_level(
     pulsar_consumer_configuration_t *consumer_configuration);
 
+/**
+ * Check whether the replicated subscription is enabled.
+ *
+ * @param consumer_configuration the consumer conf object
+ * @return whether the replicated subscription is enabled.
+ */
+PULSAR_PUBLIC int pulsar_consumer_is_replicate_subscription_state_enabled(
+    pulsar_consumer_configuration_t *consumer_configuration);
+
+/**
+ * Enable/disable replicated subscription 
+ *
+ * @param consumer_configuration the consumer conf object
+ * @param enabled A value of type int, 0: disable; 1: enable

Review comment:
       ```suggestion
    * @param enabled A value of type int. 0 means disabling replicated 
subscriptions. 1 means enabling replicated subscriptions.
   ```

##########
File path: pulsar-client-cpp/include/pulsar/c/consumer_configuration.h
##########
@@ -281,6 +281,24 @@ PULSAR_PUBLIC void 
pulsar_consumer_configuration_set_priority_level(
 PULSAR_PUBLIC int pulsar_consumer_configuration_get_priority_level(
     pulsar_consumer_configuration_t *consumer_configuration);
 
+/**
+ * Check whether the replicated subscription is enabled.
+ *
+ * @param consumer_configuration the consumer conf object
+ * @return whether the replicated subscription is enabled.
+ */
+PULSAR_PUBLIC int pulsar_consumer_is_replicate_subscription_state_enabled(
+    pulsar_consumer_configuration_t *consumer_configuration);
+
+/**
+ * Enable/disable replicated subscription 
+ *
+ * @param consumer_configuration the consumer conf object
+ * @param enabled A value of type int, 0: disable; 1: enable

Review comment:
       what's the meaning of "A value"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to