BewareMyPower commented on pull request #12917: URL: https://github.com/apache/pulsar/pull/12917#issuecomment-975405171
Please fix the checkstyle first. And could you also add tests for `useSeparateThreadPoolForProtocolHandlers` is `false`? Though it's the original behavior that has been verified by many usages of protocol handlers before, I think it's still better to cover the case in UT. Since before this PR, protocol handler start failed in setup phase, I think you can move the test logic from `setup()` to `testBootstrapProtocolHandler()` and add a `@DataProvider` for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
