Shoothzj commented on a change in pull request #12950:
URL: https://github.com/apache/pulsar/pull/12950#discussion_r755618296



##########
File path: 
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -520,6 +522,15 @@ void processArguments() throws Exception {
                 functionConfig.setCustomRuntimeOptions(customRuntimeOptions);
             }
 
+            if (secretsString != null) {
+                Type type = new TypeToken<Map<String, Object>>() {}.getType();
+                Map<String, Object> secretsMap = new 
Gson().fromJson(secretsString, type);
+                if (secretsMap == null) {
+                    secretsMap = new HashMap<>();

Review comment:
       This map still empty, or it can add elements after?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to