Jason918 commented on a change in pull request #12896:
URL: https://github.com/apache/pulsar/pull/12896#discussion_r755924005
##########
File path:
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataCacheTest.java
##########
@@ -324,13 +324,14 @@ public void insertionOutsideCache(String provider,
Supplier<String> urlSupplier)
}
@Test(dataProvider = "impl")
- public void insertionOutsideCacheWithGenericType(String provider,
Supplier<String> urlSupplier) throws Exception {
+ public void updateOutsideCacheWithGenericType(String provider,
Supplier<String> urlSupplier) throws Exception {
Review comment:
> Changed the test to `updateOutsideCacheWithGenericType` for now.
>
> I think we can implement `insertionOutsideCacheWithGenericType` by make a
path pattern registration or add a method like `accept(path)` for each
MetadataStore instance, which implies the metadata store could deserialization
this value, and the path indeed should be cached in this metadata store.
Please have a look at the conversation above with merlimat.
I am actually changing the feature for now, for a quick fix of the warning
logs.
More complex solution is need to achieve the goal of
**insertionOutsideCacheWithGenericType**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
