yuruguo commented on a change in pull request #13002:
URL: https://github.com/apache/pulsar/pull/13002#discussion_r757797252
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
##########
@@ -1808,12 +1801,13 @@ void run() throws PulsarAdminException {
description = "Maximum number of bytes in a topic backlog
before compaction is triggered "
+ "(eg: 10M, 16G, 3T). 0 disables automatic
compaction",
required = true)
- private String threshold = "0";
+ private String thresholdStr = "0";
Review comment:
I think the previous code is not easy to read, and it’s not a good way
to pass the method in the method, I prefer to pass a variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
