Jason918 commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r758061664
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/TopicStatsImpl.java
##########
@@ -76,6 +76,9 @@
/** Get estimated total unconsumed or backlog size in bytes. */
public long backlogSize;
+ /** Get the time from the oldest message in the backlog to current time. */
+ public long timeBacklogInMills;
Review comment:
Same here.
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/SubscriptionStatsImpl.java
##########
@@ -55,6 +55,9 @@
/** Size of backlog in byte. **/
public long backlogSize;
+ /** Get the time from the oldest message in the backlog to current time. */
+ public long timeBacklogInMills;
Review comment:
From description, this timeBacklogInMills should be a time period as
"current_timestamp"-"min_message_timestamp".
But it seems that it just set as min_message_timestamp?
And IMHO, name it as "backlogTime" would be more consistent with
"backlogSize"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
