massakam opened a new pull request #13063:
URL: https://github.com/apache/pulsar/pull/13063


   ### Motivation
   
   `PersistentStickyKeyDispatcherMultipleConsumers` has an instance variable 
named `allowOutOfOrderDelivery`, which is set by the first connected consumer 
and will not change unless the dispatcher is closed, such as by unloading. That 
is, end users have no way to change this setting.
   
   As with `keySharedMode`, if a consumer with a different policy connects 
after all consumers have been disconnected, the dispatcher should be closed and 
recreated.
   
https://github.com/apache/pulsar/blob/dac47cb8360c71597a2d4404c60667a769073b6e/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java#L272-L280
   
   ### Modifications
   
   If a consumer with a different `keySharedMode` or `allowOutOfOrderDelivery` 
policy tries to connect to `PersistentStickyKeyDispatcherMultipleConsumers` to 
which no consumer is connected, close that dispatcher and create a new one.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
     
   - [ ] `no-need-doc`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to