rdhabalia commented on pull request #13073: URL: https://github.com/apache/pulsar/pull/13073#issuecomment-984032733
>can you help me understand how this feature is different from the one associated with managedLedgerMaxLedgerRolloverTimeMinutes? The managed ledger uses max rollover time to scheduled a task that will close the ledger once that much time has passed (assuming the rollover criteria for size or number of entries have not yet been met). I think lowering that max time achieves the behavior proposed in this PR. No, both these configs are made to solve two different problems.`managedLedgerMaxLedgerRolloverTimeMinutes` targets max time ledger can stay opened which can be 5 hours. and `managedLedgerInActiveLedgerRolloverTimeMinutes` max time ledger can stay opened without any activity which can be 30 mins. > However, this feels like an issue that the bookkeeper client should solve. A timeout doesn't completely remove the risk and, if I understand the risk correctly, it seems like the inactivity timeout would have to be pretty low to be effective. Yes, that problem should be handled at bookkeeper client but broker can have this capability to not only solve this particular problem but allow user to control life spam of inactive topic ledgers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
