Jason918 commented on a change in pull request #13074:
URL: https://github.com/apache/pulsar/pull/13074#discussion_r760994210
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1722,6 +1723,7 @@
@FieldContext(
category = CATEGORY_LOAD_BALANCER,
+ dynamic = true,
doc = "load balance load shedding strategy"
)
private String loadBalancerLoadSheddingStrategy =
"org.apache.pulsar.broker.loadbalance.impl.OverloadShedder";
Review comment:
I get your point. But is a little confusing, if we just mark it dynamic,
but we need to restart to make it take effect.
Most importantly, we need to tell the difference that which of these dynamic
configs need broker restart, and which ones don't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
