michaeljmarshall commented on a change in pull request #13069:
URL: https://github.com/apache/pulsar/pull/13069#discussion_r761425446
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
##########
@@ -622,24 +640,33 @@ private void searchForCandidateBroker(NamespaceBundle
bundle,
}
private boolean isBrokerActive(String candidateBroker) {
- List<String> brokers =
pulsar.getLocalMetadataStore().getChildren(LoadManager.LOADBALANCE_BROKERS_ROOT).join();
-
- for (String brokerHostPort : brokers) {
- if (candidateBroker.equals("http://"; + brokerHostPort)) {
+ URI uri = URI.create(candidateBroker);
+ String candidateBrokerHostAndPort = uri.getHost() + ":" +
uri.getPort();
+ Set<String> availableBrokers = getAvailableBrokers();
+ for (String brokerHostPort : availableBrokers) {
+ if (candidateBrokerHostAndPort.equals(brokerHostPort)) {
if (LOG.isDebugEnabled()) {
- LOG.debug("Broker {} found for SLA Monitoring Namespace",
brokerHostPort);
+ LOG.debug("Broker {} is available.", brokerHostPort);
}
return true;
}
}
Review comment:
Nit: we could use
`availableBrokers.contains(candidateBrokerHostAndPort)` here, which could be a
minor optimization for clusters with many brokers and many topics getting
loaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
