bschofield commented on pull request #678:
URL: https://github.com/apache/pulsar-client-go/pull/678#issuecomment-985373428


   The concerning part is there may be a flaky TestNacksTracker() test now?
   
   I would guess that it's probably this part of newNackMockedConsumer():
   
   ```
                // since the client ticks at an interval of delay / 3
                // wait another interval to ensure we get all messages
                time.Sleep(testNackDelay + 101*time.Millisecond)
   ```
   
   Since the sleep above happens inside a new goroutine, and 
(*negativeAcksTracker).track() also runs inside a new goroutine, it's probably 
possible in rare cases for the goroutine scheduling to interfere with the 
intended sequence of actions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to